php-in-php: lazy ObOutputRuntime from ensureMinimal (#34695) - #34699
Closed
PurHur wants to merge 1 commit into
Closed
php-in-php: lazy ObOutputRuntime from ensureMinimal (#34695)#34699PurHur wants to merge 1 commit into
PurHur wants to merge 1 commit into
Conversation
Thin AOT hello-world must not NestedJIT ob_* ABI during init; ValueEchoHelper, ValueEchoRuntime, and ECHO/PRINT call sites ensureLinked before lookup (peer #34642). Co-authored-by: Cursor <cursoragent@cursor.com>
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Context::ensureMinimalUserStandaloneBodies/ full-standalone always-onObOutputRuntime::ensureLinked(peer php-in-php: drop Context ensureMinimalUserStandaloneBodies always-on StringHtmlspecialchars — lazy at call sites #34642 / Release v1.1.0: fix cold-build-check compile_failed on hello world (LLVM Module.php line 180; re-#24302) #32122.1mint class).ensureLinkedbefore__phpc_ob_echo_*inValueEchoHelper,ValueEchoRuntime::ensureLinked, JITECHO/PRINT,StringFormat,ScriptExit,ReflectionExtensionInfoRuntime.ContextMinimalStandaloneLazy*keep-lists + newContextMinimalStandaloneLazyObOutputRuntimeShrinkTest.php-src: ext/standard/output.c
Closes #34695
Test plan
./script/aot-smoke.sh→ 8 passed, 0 failed./script/phpunit.sh --filter 'ContextMinimalStandaloneLazy|ObOutputRuntimeShrink|ExamplesHelloWorldAotRegression'→ OK (36 tests, 301 assertions)php bin/compile.php -o /tmp/h34695.bin -r 'echo "hi\n";' && /tmp/h34695.bin→hiMade with Cursor