Repository navigation
php-in-php: drop Type::initialize always-on file I/O ensureLinked (#34423) - #34425
Merged
Merged
Conversation
Drop always-on NestedJIT of readfile/file_get_contents/file_put_contents and related URL helpers on the full load path so leftover Type decls cannot mint *.1 symbols (#32122). Call sites ensureLinked before lookup. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type::initializeload (peer php-in-php: drop Type::initialize always-on strip_tags/uu/quotprint/utf8 NestedJIT (__compiler_strip_tags leftover) #34414 / Release v1.1.0: fix cold-build-check compile_failed on hello world (LLVM Module.php line 180; re-#24302) #32122.1mint class).JitFileGetContents/JitFilePutContentsnowensureLinkedbefore__compiler_file_*lookup; other call sites already did.ext/standard/file.c,url.c,basic_functions.c.Test plan
./script/phpunit.sh --filter 'TypeDeadTypeInitializeLazyFileIo|TypeDead(Readfile|FileGetContents|FilePutContents|MimeContentType|GetMetaTags|ErrorLog|GetHeaders|ParseUrl)Abi'→ OK (35 tests, 157 assertions)./script/docker-exec.sh -- bash -lc 'php bin/vm.php test/repro/issue_34423_file_io_aot.php'→putget:'hi\n'/url:example.com/DONEphp bin/compile.php -o /tmp/i34423.bin … && /tmp/i34423.bin→ same output./script/aot-smoke.sh→ 8 passed, 0 failedscript/cold-build-check.sh→ ok (39s)Did not run
north-star5-verify --strict/ fullmake test-harness/./script/release-readiness.sh.Made with Cursor