Repository navigation
Stdlib: openssl_x509_read thin AOT bake via OpenSSLCertificate (#34048) - #34053
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LogicExceptiononopenssl_x509_read()happy path after Stdlib: openssl_x509_read() JIT leftover of #7268 — AOT LogicException (ext/openssl/openssl.c) #33497 baked TypeError/argc gates.VmOpensslX509Nativeand allocateOpenSSLCertificatewith__osslPem(peer#34037openssl_pkey_get_private); object/value-box args passthrough.Closes #34048
php-src
ext/openssl/xp.c—PHP_FUNCTION(openssl_x509_read)ext/openssl/openssl.stub.php—final class OpenSSLCertificateTest plan
./script/aot-smoke.sh→ 8 passed, 0 failedtest/repro/issue_34048_openssl_x509_read_aot.php→OpenSSLCertificate./script/phpunit.sh --filter Issue34048OpensslX509ReadHappyPathAotTest→ OK (3 tests, 13 assertions)php script/check-selfhost-spine-coverage-sync.php→ OK./script/phpunit.sh --filter BootstrapSelfhostBundleTest::testCompilerLibSpineSmokeBundleUnitCountAndKeyUnits→ OKVerify transcript
Made with Cursor