Skip to content

Stdlib: openssl_x509_read thin AOT bake via OpenSSLCertificate (#34048) - #34053

Merged
PurHur merged 1 commit into
masterfrom
fix/34048-openssl-x509-read-aot
Aug 23, 2026
Merged

PurHur merged 1 commit into
masterfrom
fix/34048-openssl-x509-read-aot

Conversation

@PurHur

@PurHur PurHur commented Aug 23, 2026

Copy link
Copy Markdown
Owner

Summary

Closes #34048

php-src

  • ext/openssl/xp.c — PHP_FUNCTION(openssl_x509_read)
  • ext/openssl/openssl.stub.php — final class OpenSSLCertificate

Test plan

  • ./script/aot-smoke.sh → 8 passed, 0 failed
  • VM + thin AOT test/repro/issue_34048_openssl_x509_read_aot.php → OpenSSLCertificate
  • ./script/phpunit.sh --filter Issue34048OpensslX509ReadHappyPathAotTest → OK (3 tests, 13 assertions)
  • php script/check-selfhost-spine-coverage-sync.php → OK
  • ./script/phpunit.sh --filter BootstrapSelfhostBundleTest::testCompilerLibSpineSmokeBundleUnitCountAndKeyUnits → OK

Verify transcript

aot-smoke: 8 passed, 0 failed
VM/AOT: OpenSSLCertificate
OK (3 tests, 13 assertions)
check-selfhost-spine-coverage-sync: OK
bootstrap-spine-count: 7758/7761

Made with Cursor

Compile-time PEM literals normalize through VmOpensslX509Native and allocate
OpenSSLCertificate with __osslPem (peer openssl_pkey_get_private #34037);
clears the leftover LogicException after #33497 TypeError/argc gates.

Co-authored-by: Cursor <cursoragent@cursor.com>
@PurHur
PurHur merged commit fc300bf into master Aug 23, 2026
@PurHur
PurHur deleted the fix/34048-openssl-x509-read-aot branch August 23, 2026 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stdlib: openssl_x509_read() JIT/AOT happy-path leftover of #33497 — OpenSSLCertificate object AOT (ext/openssl/xp.c)

1 participant