Trust: refresh five stale helper-runtime units (#24302) - #33997
Merged
Conversation
…#24302) DefaultTimezoneCivil emit needs HELPER_BUNDLE so NestedJIT includes the TZ helper TU. Easter date/days helpers are NestedJIT leaves (no date()/throws/ VmCalendar require) so they emit after the Civil fingerprint change. Refreshed only those five committed units; aot-smoke 8/8; release-readiness user_release_ready=yes. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
user_release_readywas no becausecheck-helper-runtime-prelink --strictreported five STALE units (DefaultTimezone ×2, EasterDate/Days, DomC14N) after Regression: AOT date T+e+O+P in one function SIGSEGV after #33958 — NestedJIT four token helpers (ext/date/php_date.c, re-#33943) #33961 Civil fingerprint churn.DefaultTimezoneCivilRuntimenow declaresHELPER_BUNDLEso--unit=NestedJITs TZ+Civil together.date()/VmCalendar/ throws) so they emit after Civil changes.Closes #24302
Test plan
./script/aot-smoke.sh→ 8/8php script/check-helper-runtime-prelink.php --strict→ 404 fresh / 0 stale / 0 broken./script/release-readiness.sh --json→user_release_ready: yes(cold-build ok; helper-runtime-prelink ok)north-star5-verify --strict/ full harnessphp-src:
ext/calendar/easter.c(easter_date/days);ext/datedefault-tz civil tokens.Made with Cursor