Repository navigation
AOT: refresh DateTime stamps after add/sub so format matches Zend (#33911) - #33913
Merged
Merged
Conversation
…3911) Compile-time interval apply wrote __dt_timestamp but left compileTimeDateTimeTimestamp / dateTimeLocalInstants stale, so getTimestamp()/format() kept returning the construct instant. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DateTime::add/subwith a knownDateInterval, refreshcompileTimeDateTimeTimestamp+dateTimeLocalInstants(or invalidate on runtime LLVM paths) soformat()/getTimestamp()no longer return the construct instant.__dt_timestamp, but reads preferred the stale stamp.Test plan
./script/aot-smoke.sh→ 8 passed, 0 failed./script/phpunit.sh --filter Issue33911DateTimeAddSubStampAotTest→ OK (3 tests, 19 assertions)#33906two-local diff still prints9ext/date/php_date.c—zim_DateTime_add/zim_DateTime_subMade with Cursor