Repository navigation
Stdlib: align max/min/pow/fdiv Reflection with Zend stubs (#25459) - #33875
Merged
Merged
Conversation
Override BuiltinInternalArgInfo return/param types so Reflection and Zend named args (pow num/exponent, fmod num1/num2) match php-src math stubs. Co-authored-by: Cursor <cursoragent@cursor.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BuiltinInternalArgInforeturn/param types formax/min/pow/fdivso Reflection matches php-src stubs (mixed/object|int|float/float).pow(num:, exponent:),fmod(num1:, num2:)) and rejects legacypow(base:).php-src
ext/standard/math.stub.php—pow/fdiv/fmodext/standard/basic_functions.stub.php—max/minTest plan
./script/docker-exec.sh -- bash -lc 'php bin/vm.php test/repro/issue_25459_max_min_pow_fdiv_reflection.php'→ Zend-matching Reflection + named args./script/phpunit.sh --filter 'MaxMinPowFdivReflection|testMaxMinPowFdivReflectionStubTypes'→ OK (3 tests, 19 assertions)./script/aot-smoke.sh→ 8/8Made with Cursor