Stdlib: SoapClient APACHE_MAP decode to assoc array (#3724) - #33595
Merged
Merged
Conversation
Match php-src to_zval_map so xsi:type Map responses become PHP arrays
instead of lists of {key,value} objects.
Co-authored-by: Cursor <cursoragent@cursor.com>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
xsi:type="…:Map"(Apache Map /APACHE_MAP) decoded as lists of{key,value}objects instead of PHP associative arrays.to_zval_mapinext/soap/php_encoding.c(string/int keys only; empty Map →null).Test plan
./script/aot-smoke.sh→ 8 passed, 0 failed (before and after)./script/docker-exec.sh -- bash -lc 'source script/php-env.sh; php test/repro/issue_3724_soap_apache_map_decode.php'→array ('k' => 'v', 7 => 'x')./script/phpunit.sh --filter 'SoapApacheMapDecodeTest|SoapVarApacheMapTest'→ OK (5 tests, 12 assertions)Does not close #3724 (parent tracking issue stays open for remaining SoapClient surface).
Made with Cursor