Skip to content

Stdlib: bake openssl_free_key() deprecated no-op for JIT/AOT (#33486) - #33488

Merged
PurHur merged 1 commit into
masterfrom
agent/issue-33486-openssl-free-key
Aug 21, 2026
Merged

PurHur merged 1 commit into
masterfrom
agent/issue-33486-openssl-free-key

Conversation

@PurHur

@PurHur PurHur commented Aug 21, 2026

Copy link
Copy Markdown
Owner

Summary

Closes #33486

Test plan

  • ./script/docker-exec.sh -- bash -lc 'php bin/vm.php test/repro/issue_33486_openssl_free_key_aot.php' → NULL
  • ./script/docker-exec.sh -- bash -lc 'php bin/compile.php -o /tmp/x test/repro/issue_33486_openssl_free_key_aot.php && /tmp/x' → NULL (E_DEPRECATED on stderr)
  • ./script/phpunit.sh --filter OpensslFreeKeyAotTest → OK (3 tests, 11 assertions)
  • ./script/aot-smoke.sh → 8/8
  • Not covered: Zend TypeError on non-key args (VM also skips that check today); openssl_pkey_free / openssl_x509_free siblings

Verify transcript

NULL
phpc build: helper-runtime cache hit ...
NULL
OK (3 tests, 11 assertions)
aot-smoke: 8 passed, 0 failed

Made with Cursor

Leftover of #7268: emit E_DEPRECATED and return null instead of LogicException,
matching the VM GC no-op path (no new runtime/*.c).

Co-authored-by: Cursor <cursoragent@cursor.com>
@PurHur
PurHur merged commit 82bd597 into master Aug 21, 2026
1 check failed
@PurHur
PurHur deleted the agent/issue-33486-openssl-free-key branch August 21, 2026 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stdlib: openssl_free_key() JIT leftover of #7268 — AOT LogicException (ext/openssl/openssl.c)

1 participant