Skip to content

php-in-php: drop leftover Type always-on xmlrpc ABI shells (#32902) - #32905

Merged
PurHur merged 1 commit into
masterfrom
fix/32902-type-dead-xmlrpc-abi
Aug 20, 2026
Merged

PurHur merged 1 commit into
masterfrom
fix/32902-type-dead-xmlrpc-abi

Conversation

@PurHur

@PurHur PurHur commented Aug 20, 2026

Copy link
Copy Markdown
Owner

Summary

php-src: ext/xmlrpc/xmlrpc.cPHP_FUNCTION(xmlrpc_encode) / xmlrpc_decode

Test plan

  • ./script/phpunit.sh --filter 'TypeDeadXmlrpcAbiRuntimeShrinkTest|TypeDeadCompilerAbiRuntimeShrinkTest|TypeDeadJsonAbiRuntimeShrinkTest'OK (11 tests, 84 assertions)
  • PHP_COMPILER_PROFILE=8.4 VM xmlrpc_encode(42) → XML int param (true string check)
  • Zend/VM/AOT json_encode/serialize neighbor sanity → {"a":1}|a:2:{…}
  • ./script/aot-smoke.sh8 passed, 0 failed
  • Note: AOT xmlrpc_encode compile-time path (JitXmlrpcCompileTime / Variable::integer()) is pre-existing red on master (xmlrpc_encode_scalar fixture); not regressed by this ABI-shell drop

Made with Cursor

Remove empty __compiler_xmlrpc_encode_value / __compiler_xmlrpc_decode decls
from Builtin\Type; StringXmlrpc owns the ABIs module-locally (getNamedFunction
first) so leftover Type shells cannot mint xmlrpc_encode.1 (#31894 / #32122).

Co-authored-by: Cursor <cursoragent@cursor.com>
@PurHur
PurHur merged commit fb72a51 into master Aug 20, 2026
1 check failed
@PurHur
PurHur deleted the fix/32902-type-dead-xmlrpc-abi branch August 20, 2026 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

php-in-php: drop leftover Type always-on xmlrpc ABI shells (ext/xmlrpc/xmlrpc.c)

1 participant