Skip to content

php-in-php: drop leftover Type always-on cslashes ABI shells (#32893) - #32894

Merged
PurHur merged 1 commit into
masterfrom
fix/32893-type-cslashes-abi-shells
Aug 20, 2026
Merged

PurHur merged 1 commit into
masterfrom
fix/32893-type-cslashes-abi-shells

Conversation

@PurHur

@PurHur PurHur commented Aug 20, 2026

Copy link
Copy Markdown
Owner

Summary

Closes #32893

Test plan

  • ./script/phpunit.sh --filter 'TypeDeadCslashesAbiRuntimeShrinkTest|CslashesRuntimeShrinkTest|StringCslashesRuntimeShrinkTest' → OK (9 tests, 44 assertions)
  • AOT addcslashes/stripcslashes match Zend (A\.B / A.B)
  • ./script/docker-exec.sh -- bash -lc './script/aot-smoke.sh' → 8/8

Made with Cursor

StringCslashes already declares addcslashes/stripcslashes via ensureBridge; remove Type empty shells that can mint addcslashes.1 (#31894 / #32122).

Co-authored-by: Cursor <cursoragent@cursor.com>
@PurHur
PurHur merged commit bf7aba1 into master Aug 20, 2026
1 check failed
@PurHur
PurHur deleted the fix/32893-type-cslashes-abi-shells branch August 20, 2026 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

php-in-php: drop leftover Type always-on addcslashes/stripcslashes ABI shells (ext/standard/string.c)

1 participant