Repository navigation
php-in-php: drop leftover Type always-on openssl_encrypt ABI shells (#32859) - #32864
Merged
Merged
Conversation
Keep OpensslEncryptRuntime::ensureLinked alongside master's StringStrtr drop (#32858). Co-authored-by: Cursor <cursoragent@cursor.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Builtin\Typealways-on empty decls for__compiler_openssl_encrypt/_decrypt/_encrypt_take_tag/_encrypt_tag_is_nullso leftover Type shells cannot mintopenssl_encrypt.1(Fix: AOT link fails for EVERY binary — duplicate memset declaration #31894 / Release v1.1.0: fix cold-build-check compile_failed on hello world (LLVM Module.php line 180; re-#24302) #32122).OpensslEncryptRuntimeowns the ABIs module-locally (getNamedFunctionfirst +declareAbi);Type::initializestillensureLinkeds it.Type.php; no newruntime/*.c. Peer of php-in-php: drop leftover Type always-on password_hash/verify/crypt ABI shells (ext/standard/password.c) #32855. Closes php-in-php: drop leftover Type always-on openssl_encrypt/decrypt ABI shells (ext/openssl/openssl.c) #32859.php-src:
ext/openssl/openssl.c(PHP_FUNCTION(openssl_encrypt)/openssl_decrypt).Test plan
./script/phpunit.sh --filter 'TypeDeadOpensslEncryptAbiRuntimeShrinkTest|OpensslEncryptRuntimeShrinkTest|OpensslEncryptRuntimeStandaloneTest|TypeDeadOpensslMethodsAbiRuntimeShrinkTest|TypeDeadPasswordCryptoAbiRuntimeShrinkTest'→ OK (16 tests, 109 assertions)./script/docker-exec.sh -- bash -lc './script/aot-smoke.sh'→ 8 passed, 0 failedMade with Cursor