Repository navigation
Language: Closure::fromCallable() and Closure::bindTo() VM (#3266) - #3275
Merged
Merged
Conversation
Add VM builtins for Closure::fromCallable (string, static, and instance method callables) and Closure::bindTo with bound $this/scope semantics matching Zend zend_closures.c; guarded by ClosureVMTest compliance cases. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closure::fromCallable()andClosure::bindTo()with Zendzend_closures.cparity for string functions, static/instance method callables, and rebound$this/scope.ClosureStatewith wrapped-callable and binding metadata; wire invocation throughinitClosureCall/applyClosureBindingso private method wrappers respect declaring-class scope..phptcases toClosureVMTest.php-src reference
Zend/zend_closures.c—zend_closure_from_callable,zend_closure_bind_toVerification
./script/docker-exec.sh -- bash -lc 'source script/php-env.sh && vendor/bin/phpunit test/compliance/ClosureVMTest.php'Closes #3266
Made with Cursor