Repository navigation
Stdlib: openssl_csr_export JIT/AOT bake leftover of #6421 (#32697) - #32700
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
openssl_csr_export()/openssl_csr_export_to_file()still threwLogicExceptionciting Stdlib: openssl_csr_new/sign/export/get_*() — CSR lifecycle API missing (ext/openssl/xp.c) #6421 while VM already exported viaVmOpensslCsrNative::normalizeCsrPem.openssl_x509_export/ Stdlib: openssl_x509_export() JIT/AOT lowering missing — VM path only (ext/openssl/openssl.c) #32557). CSR PEM andno_textmust be compile-time literals. No newruntime/*.c.php-src:
ext/openssl/xp.cPHP_FUNCTION(openssl_csr_export)/PHP_FUNCTION(openssl_csr_export_to_file)/PEM_write_bio_X509_REQ.Closes #32697
Test plan
./script/aot-smoke.sh— 8 passed, 0 failedvendor/bin/phpunit --filter 'OpensslCsrExportAotTest|OpensslCsrExportToFileAotTest|OpensslX509RuntimeShrinkTest'— OK (8 tests, 44 assertions)test/fixtures/aot/cases/openssl_csr_export.phptandopenssl_csr_export_to_file.phptDid not run
ci-fast.sh, fullAotTest, ornorth-star5-verify --strict. Capability matrix rows for these two builtins were patched by hand; a fullcapability-matrix.phprun in this container omits optional extensions (curl/intl) that committed docs still list.Made with Cursor