Repository navigation
AOT: openssl_pbkdf2 runtime LLVM kernel (HMAC over hash hex) (#32410) - #32430
Merged
Merged
Conversation
JIT leftover of #6488: PKCS#5 PBKDF2 using __compiler_hash (hex, AOT-green) plus LLVM HMAC/PBKDF2 loops. HashCrypto HMAC/PKCS5_PBKDF2_HMAC and raw hash() SIGSEGV under AOT on this tree; php-src ext/openssl/openssl.c PHP_FUNCTION(openssl_pbkdf2). Co-authored-by: Cursor <cursoragent@cursor.com>
PurHur
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
openssl_pbkdf2()works for runtime password/salt/key_length/iterations/digest_algo (bake throwsLogicExceptionon non-literals).__compiler_hashcalls + LLVM hex-decode — not HashCryptoHMAC()/PKCS5_PBKDF2_HMAC(those SIGSEGV on this tree).ext/openssl/openssl.cPHP_FUNCTION(openssl_pbkdf2)/PKCS5_PBKDF2_HMAC.Closes #32410
Test plan
./script/phpunit.sh --filter 'OpensslPbkdf2AotTest|OpensslPbkdf2JitTest|RuntimeShrinkCloseoutTest'— 7 tests OK (post-merge: 4/4 OpensslPbkdf2*)test/repro/issue_openssl_pbkdf2_aot.phpincluding$pw/$lenvariables —v1ok/v2ok/v3ok+bool(false)×2 + ValueErrorPHP_COMPILER_HELPER_RUNTIME_O=1 ./script/aot-smoke.sh— 8/8north-star5-verify --strictormake test-harness