JIT: native lowering for typed function/method returns (#55) - #3231
Merged
Merged
Conversation
Add LLVM return coercion for float and native-array `: array` returns, compliance/AOT fixtures, and compile-verify tests. Update capability matrix to reflect JIT IR support (MCJIT execute still #2055). Co-authored-by: Cursor <cursoragent@cursor.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
: string,: int,: bool,: float,: array,: ?T) on user functions and methods: arrayreturns that materialize compile-time native arrays as__hashtable__*(LLVM verify was failing with struct vs pointer mismatch)FunctionReturnTypeJitCompileTest(IR verify), and flip capability matrix JIT column to yesphp-src reference
Zend/zend_compile.c—zend_compile_returnZend/zend_execute.c—ZEND_RETURN/ZEND_RETURN_VALUEZend/zend_type.c— return type validationVerification
Note: MCJIT execute (
bin/jit.phprepro) still segfaults in this harness for all scripts (#2055), independent of return types. IR generation +compileCommon()verify pass; AOT linked binary runs the return-type fixture successfully.Closes #55
Made with Cursor