php-in-php: drop always-on LibcExtern malloc/realloc/free (#32273) - #32278
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
malloc(3)/realloc(3)/free(3)fromLibcExternand declare them module-locally viaensureMallocFamily()(canonicali8*/size_t).void*ori64size no longer mintmalloc.1(the Fix: AOT link fails for EVERY binary — duplicate memset declaration #31894 / Release v1.1.0: fix cold-build-check compile_failed on hello world (LLVM Module.php line 180; re-#24302) #32122 signature-clash class). User-script allocation staysMemoryManager__mm__malloc/__mm__realloc/__mm__free.Zend/zend_alloc.c/Zend/zend_alloc.h(Zend heap); libc malloc remains the LLVM C-buffer floor.Closes #32273
Test plan
./script/phpunit.sh --filter 'MallocRuntimeShrinkTest|LibcExternDeadDeclsRuntimeShrinkTest'./script/aot-smoke.sh(8/8) — not completed this run: first AOT compile was still in NestedJIT helper emission (ReadfileJitHelper::readfile) at 90s after theLibcExtern.phpfingerprint change; did not wait for a whole-corpus helper rebuild (20 min cap). Source shrink gates are the issue repro.Made with Cursor