Language: reject catch (Exception $this) as Zend compile fatal (#32204) - #32216
Merged
Merged
Conversation
php-src zend_compile_catch() fatals Cannot re-assign $this; this compiler previously accepted the binding and ran. Match param/global/static $this checks in Compiler.php with a VM/JIT compliance guard. Co-authored-by: Cursor <cursoragent@cursor.com>
Keep both CatchThis32204 and ReservedClassName32206 phpunit entries. Co-authored-by: Cursor <cursoragent@cursor.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
catch (Exception $this)is a Zend compile-time fatal (Cannot re-assign $this); this compiler previously accepted the binding and ran (accepted, rc=0).Compiler.phpduringOp\Stmt\TryCatchlowering, same path as param/global/static$thischecks.Zend/zend_compile.czend_compile_catch(). PHP:lib/Compiler.phpassertNoThisAsCatchVariable(). No newruntime/C.Closes #32204
Test plan
accepted)./script/phpunit.sh --filter 'CatchThisCompileFatalTest|CatchThis32204|ReassignThisCompileTest'(13 tests)Issue repro
Targeted PHPUnit
Not covered: full
VMTest/JITTestsuites (not green on master; compare by case name),ci-local.sh,north-star5-verify.Made with Cursor