Stdlib: locale_filter_matches() JIT lowering via VmLocale helper (#32119) - #32177
Merged
PurHur merged 2 commits intoAug 18, 2026
Merged
Conversation
…ib-32119-locale-filter-matches-jit
PurHur
deleted the
agent/advanced-stdlib-32119-locale-filter-matches-jit
branch
August 18, 2026 11:59
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
locale_filter_matches()JITRuntimeException(JIT lowering not implemented; use VM) with prefix-filter lowering that matches VM/VmLocale::filterMatches()(php-srcext/intl/locale/locale_methods.c).LocaleFilterMatchesJitHelper::filterMatchesArgv()via__phpc_jit_locale_filter_matches(int 0/1 → i1, peer#31966).Locale::filterMatches()(functionProxies['locale::filtermatches']). php-src-strict; no php-compiler-strict shortcut.Closes #32119
Test plan
./script/phpunit.sh --filter 'LocaleFilterMatchesJitShrinkTest|LocaleFilterMatchesJitCompileTest|LocaleFilterMatchesJit32119'.phptresult path (ordinary, named, vars, canonicalize keyword/grandfathered, unknown$langtag)./script/docker-exec.sh -- bash -lc 'php test/repro/issue_32119_locale_filter_matches_jit.php'filter_pos=true/filter_named=true/filter_vars=true/kw_f=0/kw_t=1php script/bootstrap-inventory.php --check→ OK 7586/7586locale_filter_matches(this image:extension_loaded('intl')=0; AOT fixture SKIPIFs)php-src:
ext/intl/locale/locale_methods.c,ext/intl/php_intl.stub.phpPHP:
ext/intl/JitLocaleFilterMatches.php,ext/intl/LocaleFilterMatchesJitHelper.php,lib/JIT/Builtin/LocaleFilterMatchesRuntime.phpMade with Cursor