Stdlib: zip_open named filename + zip_* stub param names (#24666)

[PurHur]

Summary

• Wire BuiltinParamNames for procedural zip_* to php-src ext/zip/php_zip.stub.php so named calls match Zend (zip_open(filename:); zip_entry_close(zip_entry:) instead of InternalArgInfo zip_ent).
• Pass explicit TypeError param names into VmZipProcedural::requireArchiveHandle() so zip_close/zip_read use $zip and zip_entry_open uses $zip_dp (was hardcoded $filename for arg Php stdlib specs implementation #1).
• PHP-in-PHP only; zip remains gated by host ext/zip or PHP_COMPILER_ENABLE_ZIP=1 (Regression: extension_loaded('zip')/ZipArchive/zip_open phantom under PROFILE=8.4 — Zend ext/zip absent (re-#18137, ext/zip) #25010).

Closes #24666

php-src reference

• ext/zip/php_zip.stub.php — zip_open(string $filename), zip_close($zip), zip_entry_close($zip_entry), …

PHP implementation

• lib/BuiltinParamNames.php — explicit stub names
• ext/zip/VmZipProcedural.php + zip_close.php / zip_read.php / zip_entry_open.php — TypeError labels

Test plan

• Issue repro (zip enabled):

  ./script/docker-exec.sh -- bash -lc 'PHP_COMPILER_ENABLE_ZIP=1 php bin/vm.php test/repro/issue_24666_zip_open_named.php'
  

  Output:

  params=filename
  pos=false
  named=false
  close_params=zip_entry
  zip_entry=zip_entry_close(): Argument #1 ($zip_entry) must be of type resource, bool given
  zip_ent=Unknown named parameter $zip_ent
  

• ./script/docker-exec.sh -- bash -lc 'source script/php-env.sh && vendor/bin/phpunit --filter ZipModuleTest test/unit/ZipModuleTest.php' — OK (2 tests)
• vendor/bin/phpunit --filter testZipProceduralZendStubNamedParams — OK (29 assertions)
• vendor/bin/phpunit test/unit/ZipArchiveTest.php test/unit/ZipExtensionPolicyTest.php — OK (80 assertions)
• Not run: ci-fast.sh, AOT (procedural zip is VM-only, Stdlib: zip_open()/zip_read()/zip_close()/zip_entry_*() — procedural zip API missing (ext/zip/php_zip.c) #6370), north-star5-verify

Made with Cursor