Stdlib: lower ldap_set_option/ldap_get_option through JIT helper bridges (#32107)

[PurHur]

Summary

• JIT/AOT no longer throw LogicException for ldap_set_option() / ldap_get_option(); lowering goes through LdapLinkJitHelper + LdapRuntime bridges that reuse VmLdapNative::setOptionInt / getOptionInt (php-src ext/ldap/ldap.c).
• Accepts LDAP\Connection|null, int option, and the by-ref $retval out-arg; int/bool value subset matches VM.
• Closes Stdlib: ldap_set_option()/ldap_get_option() JIT lowering missing — VM path only (ext/ldap/ldap.c) #32107

php-src reference

• https://github.com/php/php-src/blob/master/ext/ldap/ldap.c (PHP_FUNCTION(ldap_set_option), ldap_get_option)

PHP implementation

• ext/ldap/ldap_link_builtins.php — call() → JitLdapLink::invokeSetOption / invokeGetOption
• ext/ldap/JitLdapLink.php + ext/ldap/LdapLinkJitHelper.php — NestedJIT helpers
• lib/JIT/Builtin/LdapRuntime.php — __compiler_ldap_set_option / __compiler_ldap_get_option / __compiler_ldap_get_option_value

Test plan

• Issue repro VM + JIT
• Targeted PHPUnit (LdapSetGetOption*, related ldap helper tests)
• php script/bootstrap-inventory.php --check (7578/7578)
• Full ./script/ci-fast.sh — not re-run here; AOT phpc build of this repro hits the same pre-existing NestedJIT __compiler_sprintf link miss as already-merged Stdlib: ldap_errno()/ldap_error()/ldap_err2str() JIT lowering missing — VM path only (ext/ldap/ldap.c) #32106

Verification

./script/docker-exec.sh -- bash -lc 'PHP_COMPILER_ENABLE_LDAP=1 php bin/vm.php test/repro/issue_32107_ldap_set_get_option_jit.php'
fn=1
set=1
get=1
val=3
null_set=1
null_get=1
null_val=3
bad_conn=typeerror
ok

./script/docker-exec.sh -- bash -lc 'PHP_COMPILER_ENABLE_LDAP=1 php bin/jit.php test/repro/issue_32107_ldap_set_get_option_jit.php'
fn=1
set=1
get=1
val=3
null_set=1
null_get=1
null_val=3
bad_conn=typeerror
ok

./script/phpunit.sh --filter 'LdapSetGetOption'
OK (7 tests, 23 assertions)

./script/phpunit.sh --filter 'Ldap(SetGetOption|ErrnoError|Bind|Unbind|Connect|RuntimeShrink)JitHelperTest|LdapRuntimeShrinkTest'
OK (20 tests, 100 assertions, 2 skipped)

php script/bootstrap-inventory.php --check
OK 7578/7578

AOT ./phpc build of this repro (and of already-merged #32106 errno repro) fails at link with undefined __compiler_sprintf inside LdapLinkJitHelper::requireConnection — pre-existing NestedJIT AOT gap, not introduced here.

Made with Cursor