Fix cold-build hello-world AOT verification on fresh helper cache (#32122) - #32125
Merged
Merged
Conversation
…2122) Restore the canonical snprintf prototype for WeakRefRegistry and reopen a valid insert block before catchable-error fallback raises, so standalone hello-world builds verify again in the release cold-build gate. Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
snprintfprototype inWeakRefRegistryRuntimeso standalone AOT modules stop poisoning the shared libc declaration tableTryCatchHelperfalls back toErrorRaise, which keeps nested helper compiles from emitting orphaned catchable-error callsTest plan
./script/phpunit.sh --filter 'SnprintfRuntimeShrinkTest|TryCatchRuntimeShrinkTest'OK (8 tests, 24 assertions)./script/docker-exec.sh -- bash -lc "tmp=\$(mktemp -d); printf '%s\n' '<?php echo \"hi\\n\";' > \"\$tmp/hello.php\"; php bin/compile.php -o \"\$tmp/hello.bin\" \"\$tmp/hello.php\" && \"\$tmp/hello.bin\""hi./script/docker-exec.sh -- bash -lc 'script/cold-build-check.sh'cold-build-check: ok — clean-checkout compile of hello world took 6s (budget 120s)./script/docker-exec.sh -- bash -lc './script/release-readiness.sh --json'"user_release_ready": "yes""cold-build": "ok"in the gate list withclean-checkout compile of hello world took 6s (budget 120s)./script/ci-fast.shcheck-init-miniwebapp-parity: drift in src/Router.php/templates/init-miniwebappsync, outside this diffCloses #32122.
Made with Cursor