Stdlib: htmlspecialchars ENT_DISALLOWED replaces illegal scalars with U+FFFD (#32084) - #32099
Merged
Merged
Conversation
… U+FFFD (#32084) php-src html.c unicode_cp_is_allowed maps C0/DEL/HTML5 noncharacters to U+FFFD when ENT_DISALLOWED is set. Match that in VmString and NestedJIT helpers. Co-authored-by: Cursor <cursoragent@cursor.com>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ext/standard/html.cunicode_cp_is_allowed()maps C0 controls, DEL, and HTML5 noncharacters to U+FFFD whenENT_DISALLOWEDis set. VM/JIT copied those bytes through.VmString::htmlspecialchars()/htmlentities()and the NestedJIT helpers (HtmlspecialcharsJitHelper,HtmlEntitiesJitHelper). No newruntime/*.c.php-src reference: php/php-src
ext/standard/html.c—php_escape_html_entities_ex/unicode_cp_is_allowed. PHP implementation:ext/standard/VmString.php.Test plan
HtmlspecialcharsEntDisallowed, helper shrink tests, ENT_IGNORE regression)Verification
Zend:
Not covered: full
make test-harness,ci-local.shLLVM,north-star5-verify.check-generated-docs.shis red on master (capability-matrix/syntax drift) independent of this diff.Made with Cursor