php-in-php: drop always-on LibcExtern snprintf after NestedJIT module-local (#32092) - #32093
Merged
Conversation
…-local (#32092) User-script sprintf()/printf() already live in JitPrintf / SprintfSnprintfRuntime. NestedJIT C-string format leaves now call ensureSnprintf() instead of an always-on libc row. Co-authored-by: Cursor <cursoragent@cursor.com>
Closed
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LibcExternsnprintf(3)row after NestedJIT leaves callensureSnprintf()(peer#32068strlen /#31706printf).sprintf()/printf()stay onJitPrintf/SprintfSnprintfRuntime(php-srcext/standard/formatted_print.c); EMBED MCJIT keeps__phpc_host_snprintf.ensureSnprintfinJitNlLanginfoandJitDateintoLibcExtern::ensureSnprintf.Closes #32092
php-src:
ext/standard/formatted_print.c,ext/standard/math.cPHP:
lib/JIT/LibcExtern.php(ensureSnprintf), NestedJIT consumersC surface: always-on
'snprintf' =>row removed fromLibcExtern::register(); two per-kernel local decl helpers deleted (JitNlLanginfo::ensureSnprintf,JitDate::ensureSnprintf). Thin ABI trampoline remains asensureSnprintf()for NestedJIT C-string format.Test plan
./script/phpunit.sh --filter 'LibcExternDeadDeclsRuntimeShrinkTest|SnprintfRuntimeShrinkTest|LibcExternMathRuntimeShrinkTest'OK (34 tests, 624 assertions)./script/docker-exec.sh -- bash -lc 'php bin/vm.php /tmp/snprintf_smoke.php'→12/ff/42(decoct(10),dechex(255),sprintf("%d", 42))ci-fast.sh/ LLVM compile not run (static shrink + VM smoke only; same gate class as php-in-php: drop always-on LibcExtern strlen after NestedJIT module-local (#31997 shape) #32068)Made with Cursor