php-in-php: drop always-on LibcExtern strlen after NestedJIT module-local (#32068) - #32072
Merged
Merged
Conversation
…ocal (#32068) User-script strlen() already lives in ext/types JitStrlen / VmString. NestedJIT C-string length leaves now call ensureStrlenDecl() instead of an always-on libc row. Co-authored-by: Cursor <cursoragent@cursor.com>
Closed
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LibcExternstrlen(3)row. User-scriptstrlen()already lives in PHP (ext/types/strlen.php+JitStrlen/VmString::byteLength).LibcExtern::ensureStrlenDecl()beforelookupFunction('strlen'). EMBED MCJIT still getsimplementStrlenBodyafter the module-local decl.Module::jitInitalways-onstrlenfallback (peer php-in-php: drop always-on LibcExtern strtod after NestedJIT module-local (#31988 shape) #31997 strtod).Closes #32068
php-src:
ext/standard/string.cPHP_FUNCTION(strlen)/ ZendZ_STRLEN— not libcstrlenon user values.C runtime: no
runtime/*.cadded. Always-on libcstrlenrow removed fromlib/JIT/LibcExtern.php('strlen' =>gone); thinensureStrlenDecl()trampoline only.Test plan
./script/phpunit.sh --filter 'LibcExternDeadDeclsRuntimeShrinkTest|StrlenRuntimeShrinkTest|LibcExternMathRuntimeShrinkTest'./script/docker-exec.sh -- bash -lc 'php bin/vm.php test/repro/nested_trim_strlen.php'→5Did not run
make test-harness/ci-local.sh/ bootstrap link (not compile/link/self-host).Made with Cursor