Language: encapsed Undefined variable Warning cites user site (#32034) - #32059
Merged
Conversation
Stamp ConcatList CONCAT/CAST_STRING with the interpolated expression line so VM/JIT FETCH_R warnings match Zend instead of the prior statement opline. Co-authored-by: Cursor <cursoragent@cursor.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
$undefinedwarnings cited the previous statement (oftenerror_reportingon line 2) because ConcatListCONCAT/CAST_STRINGopcodes had nosourceLocation.KIND_HEREDOC) and advance JITcallSiteLinefrom opcodesourceLocation.Zend/zend_compile.czend_compile_encapsed_stringFETCH_R lineno. PHP:lib/Compiler.phpConcatList lowering +lib/JIT.phpopline stamp.Closes #32034
Test plan
./script/phpunit.sh --filter EncapsedUndefVarWarningLine32034ListDestructUndefKeyLine31994,ForeachScalarWarningLine,EncapsedCoalesce)VMTest/JITTestnot run (path-slash--filteron those suites is known-broken; dedicated providers cover this case)Verification
VM (matches Zend): warnings on lines 3, 4, 5, 6 (was 2, 3, 3, 3).
VM (matches Zend): warning on line 4 (was 2).
JIT same lines as Zend.
OK (VM + JIT dedicated PHPT).
php-src-strict; no php-compiler-strict shortcut. No new
runtime/*.c.Made with Cursor