Language: magic __get/__set pre/post dec no Undefined property (#32014) - #32023
Merged
Merged
Conversation
Repro scripts and VM/JIT .phpt lock in silent __get/__set behavior for --$obj->n and $obj->n-- covered by the #31992 inc/dec guard in lib/VM.php and lib/JIT.php; register inc/dec suites in phpunit.xml.dist. Co-authored-by: Cursor <cursoragent@cursor.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.phptfor--$obj->n/$obj->n--with__get/__set— noUndefined propertywarning, values match Zend (dec=0,postdec=0).lib/VM.php/lib/JIT.php(propertyFetchDestUsedAsIncDecincludesPRE_DEC/POST_DEC; skip warn whenpropertyReadUsesMagicGet).phpunit.xml.dist.php-src reference
Zend/zend_object_handlers.c— magic read/write for inc/decZend/zend_vm_def.h—ZEND_PRE_DEC_OBJ,ZEND_POST_DEC_OBJVerification
Not covered: AOT magic property inc/dec value correctness (pre-existing gap — AOT returns stale
inc=1/dec=1; tracked separately in AOT inventory).Closes #32014
Made with Cursor