AOT: remaining unimplemented lowering rows (#31967) - #32012
Closed
PurHur wants to merge 1 commit into
Closed
Conversation
…erface const, static array store (#31967) Fix strtol assignment sites blocked by #31988, variable static calls via runtime class id, interface self:: const inheritance at JIT define time, enum case class constants after DECLARE_ENUM, and boxed static array property stores. Guard with Issue31967RemainingAotTest. Co-authored-by: Cursor <cursoragent@cursor.com>
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
$obj::method()via runtime class id +ClassConstFetchHelper::emitResolveClassId.const Y = self::Xat JIT define time (interfaces beforecompileClass, inherited const walk).DECLARE_ENUM; flush pending consts with insert-block restore.JitValueBox::assignToPointerfallback.Closes #31967
php-src reference
Zend/zend_execute.c—ZEND_INIT_STATIC_METHOD_CALL(variable static call)Zend/zend_constants.c—zend_get_class_constant_ex(interface inherited consts)Zend/zend_compile.c— enum case in class constant exprVerification
Not covered: full
./script/ci-local.sh, differential sweep (no call/operand lowering shape change beyond the four rows),ClassConstEnumCaseJitCompileTest(already errors on master duringjitCompileBlock, before this PR's AOT path).Made with Cursor