Stdlib: normalizer_normalize Reflection $string/$form NFC + string|false (#25586) - #31908
Merged
PurHur merged 1 commit intoAug 17, 2026
Merged
Conversation
…lse (#25586) Match php-src normalizer.stub.php names and types so named string: works and input: is rejected like Zend. Co-authored-by: Cursor <cursoragent@cursor.com>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
normalizer_normalizeReflection/named args with php-srcext/intl/normalizer/normalizer.stub.php:$string: string,$form: int = Normalizer::FORM_C(16), returnstring|false.string:/form:accepted; legacy InternalArgInfoinput:rejected like Zend. Positional NFC (e+ combining acute →c3a9) unchanged.php-src reference
ext/intl/normalizer/normalizer.stub.php—normalizer_normalize(string $string, int $form = Normalizer::FORM_C): string|falsePHP implementation
lib/BuiltinParamNames.php,lib/BuiltinInternalArgInfo.php,lib/BuiltinInternalDefaultValues.php— stub overrides (no newruntime/*.c)Test plan
vendor/bin/phpunit --filter testNormalizerNormalizeReflectionStubTypes— OK (1 test, 20 assertions)vendor/bin/phpunit --filter VmNormalizerTest— OK (5 tests, 11 assertions), including force-register Reflection + named-arg pathphp test/repro/issue_25586_normalizer_normalize_reflection.php—named=c3a9,legacy=Unknown named parameter $input,positional=c3a9vendor/bin/phpunit --filter NormalizerNormalizeReflectionVMTest— skipped (SKIPIFhost php-intl; Docker Regression: extension_loaded('intl') phantom true — grapheme_* register unloaded ext (re-#11472, ext/standard/info.c) #22691)./script/ci-fast.sh— not completed this run: AOT build smoke hung (~24 min; wall target <15s). Stopped only that worker container. Open Fix: AOT link fails for EVERY binary — duplicate memset declaration #31894 reports AOT link failing for every binary (duplicate memset) on master.Made with Cursor