Skip to content

Stdlib: DOM soft-null deprecation cites Zend stub param names (#31824) - #31826

Merged
PurHur merged 1 commit into
masterfrom
agent/issue-31824-dom-soft-null-param-names
Aug 17, 2026
Merged

Stdlib: DOM soft-null deprecation cites Zend stub param names (#31824)#31826
PurHur merged 1 commit into
masterfrom
agent/issue-31824-dom-soft-null-param-names

Conversation

@PurHur

@PurHur PurHur commented Aug 17, 2026

Copy link
Copy Markdown
Owner

Summary

Closes #31824

Test plan

  • ./script/docker-exec.sh -- bash -lc 'php test/repro/maintainer_gap_dom_soft_null_param_names.php'
  • ./script/docker-exec.sh -- bash -lc 'php bin/vm.php test/repro/maintainer_gap_dom_soft_null_param_names.php'
  • ./script/docker-exec.sh -- bash -lc 'php bin/jit.php test/repro/maintainer_gap_dom_soft_null_param_names.php'
  • ./script/phpunit.sh --filter DomSoftNullParamNamesDeprecated → OK (2 tests)

Verification transcript (VM excerpt)

DEP:DOMNamedNodeMap::getNamedItem(): Passing null to parameter #1 ($qualifiedName) of type string is deprecated
DEP:DOMDocument::load(): Passing null to parameter #1 ($filename) of type string is deprecated
… (matches Zend 8.2.32)
ok

Made with Cursor

Pass php-src stub names into DomClassMethod/VmDomJitDispatch stringArg so E_DEPRECATED no longer defaults to $value for getNamedItem, load/saveHTMLFile, isSupported/hasFeature, and related DOM APIs.

Co-authored-by: Cursor <cursoragent@cursor.com>
@PurHur
PurHur merged commit 9fe4148 into master Aug 17, 2026
1 check failed
@PurHur
PurHur deleted the agent/issue-31824-dom-soft-null-param-names branch August 17, 2026 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Regression: DOM soft-null deprecation cites $value — Zend stub names (qualifiedName/filename/feature/…) (ext/dom)

1 participant