Stdlib: DOM soft-null deprecation cites Zend stub param names (#31824) - #31826
Merged
Conversation
Pass php-src stub names into DomClassMethod/VmDomJitDispatch stringArg so E_DEPRECATED no longer defaults to $value for getNamedItem, load/saveHTMLFile, isSupported/hasFeature, and related DOM APIs. Co-authored-by: Cursor <cursoragent@cursor.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
E_DEPRECATEDfor several DOM APIs cited default$valueinstead of Zend stub names ($qualifiedName,$filename,$feature,$version,$localName,$data).DomClassMethod::stringArg()/VmDomJitDispatch::stringArg()for the methods in Regression: DOM soft-null deprecation cites $value — Zend stub names (qualifiedName/filename/feature/…) (ext/dom) #31824; add repro + VM/JIT compliance guard.ext/dom/php_dom.stub.php,ext/dom/namednodemap.c. No newruntime/*.c.Closes #31824
Test plan
./script/docker-exec.sh -- bash -lc 'php test/repro/maintainer_gap_dom_soft_null_param_names.php'./script/docker-exec.sh -- bash -lc 'php bin/vm.php test/repro/maintainer_gap_dom_soft_null_param_names.php'./script/docker-exec.sh -- bash -lc 'php bin/jit.php test/repro/maintainer_gap_dom_soft_null_param_names.php'./script/phpunit.sh --filter DomSoftNullParamNamesDeprecated→ OK (2 tests)Verification transcript (VM excerpt)
Made with Cursor