php-in-php: drop always-on LibcExtern strncasecmp (#31682) - #31685
Merged
Conversation
Route Object_ class-id and filter_var boolean token compares through __compiler_strncasecmp so always-on libc strncasecmp is no longer needed. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LibcExtern'strncasecmp'row after routing the last NestedJIT consumers through__compiler_strncasecmp(StringCaseCompare::ABI_STRNCASECMP).Object_::classIdFromRuntimeNameandJitFilter::parseBooleanStringTokenalready ensured CaseCompare; they now look up the compiler ABI instead of libc.strncasecmp()unchanged (CaseCompareJitHelper / VmString).LibcNameCollisionRuntimeShrinkTeststrcoll expectation (php-in-php: drop always-on LibcExtern strcoll after StringStrcoll trampoline (#31458 shape) #31498 already dropped the row).Closes #31682
C / always-on shrink
lib/JIT/LibcExtern.php(strncasecmp).lib/AOT/runtime/*.cstill empty (no new C).Test plan
./script/phpunit.sh --filter 'LibcExternDeadDeclsRuntimeShrinkTest|LibcNameCollisionRuntimeShrinkTest|StrcasecmpRuntimeShrinkTest::testObjectTypeRoutesStrncasecmpThroughCaseCompare|StrcasecmpRuntimeShrinkTest::testStrncasecmp'→ OK (20 tests, 181 assertions)./script/docker-exec.sh -- bash -lc 'php bin/vm.php -r '\''var_dump(strncasecmp("Ab","ab",1)); var_dump(filter_var("TRUE", FILTER_VALIDATE_BOOLEAN));'\'''→int(0)/bool(true)php bin/jit.php→int(0)/bool(true)php-src reference
ext/standard/string.c—PHP_FUNCTION(strncasecmp)(semantics stay in PHP)ext/filter/logical_filters.c— boolean token parse (JitFilter mirrors VmFilter)Made with Cursor