Stdlib: XMLWriter null string args soft-deprecate like Zend (#31610) - #31613
Merged
Conversation
Z_PARAM_STR soft-null DEP+coerce for class/procedural string params, and match php-src empty-name ValueError ordinals (Argument #2 quirks). Co-authored-by: Cursor <cursoragent@cursor.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
E_DEPRECATED+ coerce forXMLWriter/xmlwriter_*Z_PARAM_STR args (php-srcphp_xmlwriter.c), same shape as SimpleXML Regression: SimpleXMLElement::addChild/addAttribute(null) TypeError — Zend Deprecated + ValueError empty (ext/simplexml/sxe.c) #31554.ValueErrorordinals (Argument #2quirks forstartElement/writeElement/startAttribute/writeAttribute).Test plan
./script/docker-exec.sh -- bash -lc 'php test/repro/maintainer_gap_xmlwriter_null_soft.php'(Zend baseline)./script/docker-exec.sh -- bash -lc 'php bin/vm.php test/repro/maintainer_gap_xmlwriter_null_soft.php'./script/docker-exec.sh -- bash -lc 'php bin/jit.php test/repro/maintainer_gap_xmlwriter_null_soft.php'vendor/bin/phpunit test/compliance/XmlwriterNullStringArgsSoft31610VMTest.php— OKvendor/bin/phpunit test/compliance/XmlwriterNullStringArgsSoft31610JITTest.php— OKVerification transcript (VM = Zend)
php-src-strict; no new
runtime/*.c.Made with Cursor