Skip to content

Stdlib: XMLWriter null string args soft-deprecate like Zend (#31610) - #31613

Merged
PurHur merged 1 commit into
masterfrom
agent/ext-dom-xmlwriter-null-soft-31610
Aug 16, 2026
Merged

Stdlib: XMLWriter null string args soft-deprecate like Zend (#31610)#31613
PurHur merged 1 commit into
masterfrom
agent/ext-dom-xmlwriter-null-soft-31610

Conversation

@PurHur

@PurHur PurHur commented Aug 16, 2026

Copy link
Copy Markdown
Owner

Summary

Test plan

  • ./script/docker-exec.sh -- bash -lc 'php test/repro/maintainer_gap_xmlwriter_null_soft.php' (Zend baseline)
  • ./script/docker-exec.sh -- bash -lc 'php bin/vm.php test/repro/maintainer_gap_xmlwriter_null_soft.php'
  • ./script/docker-exec.sh -- bash -lc 'php bin/jit.php test/repro/maintainer_gap_xmlwriter_null_soft.php'
  • vendor/bin/phpunit test/compliance/XmlwriterNullStringArgsSoft31610VMTest.php — OK
  • vendor/bin/phpunit test/compliance/XmlwriterNullStringArgsSoft31610JITTest.php — OK

Verification transcript (VM = Zend)

DEP:XMLWriter::startElement(): Passing null to parameter #1 ($name) of type string is deprecated
ValueError: XMLWriter::startElement(): Argument #2 must be a valid element name, "" given
… (writeElement/startAttribute/writeAttribute + content methods ok)

php-src-strict; no new runtime/*.c.

Made with Cursor

Z_PARAM_STR soft-null DEP+coerce for class/procedural string params, and
match php-src empty-name ValueError ordinals (Argument #2 quirks).

Co-authored-by: Cursor <cursoragent@cursor.com>
@PurHur
PurHur merged commit 3764959 into master Aug 16, 2026
1 check failed
@PurHur
PurHur deleted the agent/ext-dom-xmlwriter-null-soft-31610 branch August 16, 2026 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Regression: XMLWriter string args (null) skip soft-null DEP + ValueError arg shape — Zend php_xmlwriter.c

1 participant