Stdlib: get_browser Reflection/named params user_agent (#23382) - #31580
Merged
Merged
Conversation
Match php-src basic_functions.stub.php so Reflection and named calls use $user_agent instead of the legacy $browser_name label. Co-authored-by: Cursor <cursoragent@cursor.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_browserReflection/named-arg param names with php-srcbasic_functions.stub.php(user_agent,return_array).$user_agentin VM/JIT string-coercion TypeErrors; add focused PHPT + repro.Closes #23382
php-src reference
ext/standard/basic_functions.stub.php—get_browser(?string $user_agent = null, bool $return_array = false)lib/BuiltinParamNames.php,ext/standard/get_browser.phpTest plan
./script/docker-exec.sh -- bash -lc 'php bin/vm.php test/repro/issue_23382_get_browser_reflection.php'./script/docker-exec.sh -- bash -lc 'php bin/jit.php test/repro/issue_23382_get_browser_reflection.php'./script/phpunit.sh --filter GetBrowserReflectionNamed23382Verification output
Made with Cursor