Stdlib: array_slice/chunk/reverse null preserve_keys DEP+coerce (#31442) - #31454
Merged
Merged
Conversation
Match php-src Z_PARAM_BOOL under non-strict (E_DEPRECATED + false); keep TypeError under strict_types. Reuses parseBoolBuiltinArgForFrame / JitBoolArg::lowerCoerceZParamBool like iterator_to_array (#31340). Co-authored-by: Cursor <cursoragent@cursor.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
array_slice/array_chunk/array_reverse$preserve_keys=nullnow matches php-srcZ_PARAM_BOOL:E_DEPRECATED+ coerce tofalse(re-Regression: array_chunk()/array_reverse() null preserve_keys coerced — Zend TypeError (ext/standard/array.c) #24693).declare(strict_types=1)still raisesTypeError(unchanged).VmMath::parseBoolBuiltinArgForFrame; JIT/AOT usesJitBoolArg::lowerCoerceZParamBool(same path asiterator_to_arrayRegression: iterator_to_array(..., null) $preserve_keys under strict_types succeeds — Zend TypeError (ext/spl/iterator.c) #31340). No newruntime/*.c.php-src:
ext/standard/array.c(PHP_FUNCTION(array_slice|array_chunk|array_reverse)), stubbool $preserve_keys = false.Test plan
./script/docker-exec.sh -- bash -lc 'php bin/vm.php test/repro/maintainer_gap_array_preserve_keys_null.php'./script/docker-exec.sh -- bash -lc 'php bin/vm.php test/repro/issue_31442_array_preserve_keys_null_strict.php'./script/docker-exec.sh -- bash -lc 'php bin/jit.php test/repro/maintainer_gap_array_preserve_keys_null.php'./script/phpunit.sh --filter 'ArrayPreserveKeysNull31442|array_preserve_keys_null'→ OK (6 tests)php bin/compile.php -o … test/repro/issue_31442_array_preserve_keys_null_aot{,_strict}.php(slice+chunk; reverse AOT IR verify is pre-existing)Closes #31442
Made with Cursor