Stdlib: stream_filter_* null filter_name TypeError under strict_types (#31408) - #31438
Merged
Merged
Conversation
…#31408) Match php-src Z_PARAM_STR for $filter_name on append/prepend — InternalStrictArg on VM and lowerStrictOrCoercible + dead-BB seal on JIT/AOT. Co-authored-by: Cursor <cursoragent@cursor.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
declare(strict_types=1),stream_filter_append/prependnull$filter_namenow raises Zend-shapedTypeError(Argument Php stdlib specs implementation #2) instead of soft-coercing to""and warningunable to locate filter "".InternalStrictArg::resolveCoercibleStringArg; JIT/AOT usesJitStringBuiltinArg::lowerStrictOrCoerciblewithfilter_nameand a dead-BB seal after catchable TypeError (peer of Regression: dl(null) under strict_types Deprecated+Warning — Zend TypeError (ext/standard/dl.c) #30250JitDl).ext/standard/streamsfuncs.c,basic_functions.stub.php—string $filter_name.Closes #31408
Test plan
./script/docker-exec.sh -- bash -lc 'php bin/vm.php test/repro/maintainer_gap_stream_filter_append_null_name.php'$filter_name./script/phpunit.sh --filter Issue31408StreamFilterNullNameStrictTest— OK (1 test)./script/phpunit.sh --filter Issue31408StreamFilterNullNameStrictAotTest— OK (1 test, 11 assertions, 3× AOT run)false(no TypeError)Made with Cursor