feat(jit): closure use (&$var) by-reference lowering (#72) - #3108
Merged
Conversation
Mirror VM bindClosureCaptures indirect path: referenceCapture passes live enclosing variables through ClosureWithCaptures, and compileBlock aliases capture slots to the __value__* param instead of snapshotting by value. Co-authored-by: Cursor <cursoragent@cursor.com>
Wire compileBlock capture params to live __value__* storage via valueBoxAliasPtr so by-reference use() mirrors VM bindClosureCallCaptures. Co-authored-by: Cursor <cursoragent@cursor.com>
PurHur
force-pushed
the
feat/jit-closure-use-byref-72
branch
from
May 29, 2026 13:30
a7b4e73 to
e523d80
Compare
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
use (&$var)closure captures, mirroring the VMbindClosureCaptures/bindClosureCallCapturesindirect path.ClosureHelper::referenceCapturepasses live enclosing variables throughClosureWithCaptures;compileBlockaliases by-ref capture slots to the trailing__value__*param (foreach by-ref pattern) instead of snapshotting.closure_use_byref.phptcompliance case and extendClosureJitCompileTestIR verify coverage.Test plan
phpunit test/compliance/ClosureVMTest.php(includesclosure_use_byref.phpt)phpunit test/unit/ClosureJitCompileTest.php --filter testClosureModuleVerifybin/jit.php -rMCJIT runtime (skipped here: probe segfaults in CI env; IR verify passes)Limitations
ClosureJitCompileTest.Made with Cursor