feat(#3038): JIT unit probe inventory compile_driver emit path - #3051
Merged
Merged
Conversation
Wire test/selfhost/jit_unit_probe/compile_driver.php into the strict bootstrap probe (default on BOOTSTRAP_M3_JIT_UNIT_PROBE_STRICT=1), retiring the dedicated emit-helper TU for native emit when inventory driver is enabled — parity with compiler_unit_probe (#2879). Verified: make bootstrap-selfhost-jit-unit-probe-strict → emit_path=native vendor/bin/phpunit --filter BootstrapJitUnitProbeTest → 14/14 OK Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test/selfhost/jit_unit_probe/compile_driver.php— inventory-scale M3 emit driver for the JIT unit probe (parity withcompiler_unit_probe/compile_driver.php, Self-host M3: inventory emit driver for unit probes (retire *_m3_emit_native_entry.php) #2879).bootstrap-selfhost-jit-unit-probe.shto prefer inventorycompile_driverwhenBOOTSTRAP_M3_JIT_UNIT_PROBE_STRICT=1(default) orBOOTSTRAP_M3_USE_INVENTORY_EMIT_DRIVER=1; bisect withBOOTSTRAP_M3_USE_INVENTORY_EMIT_DRIVER=0to forcejit_unit_probe_m3_emit_native_entry.php.BOOTSTRAP_M3_USE_INVENTORY_EMIT_DRIVER=1explicitly.Advances #2879 / #3032 (retire
*_m3_emit_native_entry.phpfor JIT probe).Test plan
Verified (Docker):
Closes #3038
Made with Cursor