Skip to content

feat(#3038): JIT unit probe inventory compile_driver emit path - #3051

Merged
PurHur merged 1 commit into
masterfrom
issue-3038-jit-unit-probe-inventory-emit
May 29, 2026
Merged

PurHur merged 1 commit into
masterfrom
issue-3038-jit-unit-probe-inventory-emit

Conversation

@PurHur

@PurHur PurHur commented May 29, 2026

Copy link
Copy Markdown
Owner

Summary

  • Add test/selfhost/jit_unit_probe/compile_driver.php — inventory-scale M3 emit driver for the JIT unit probe (parity with compiler_unit_probe/compile_driver.php, Self-host M3: inventory emit driver for unit probes (retire *_m3_emit_native_entry.php) #2879).
  • Update bootstrap-selfhost-jit-unit-probe.sh to prefer inventory compile_driver when BOOTSTRAP_M3_JIT_UNIT_PROBE_STRICT=1 (default) or BOOTSTRAP_M3_USE_INVENTORY_EMIT_DRIVER=1; bisect with BOOTSTRAP_M3_USE_INVENTORY_EMIT_DRIVER=0 to force jit_unit_probe_m3_emit_native_entry.php.
  • Makefile strict target sets BOOTSTRAP_M3_USE_INVENTORY_EMIT_DRIVER=1 explicitly.

Advances #2879 / #3032 (retire *_m3_emit_native_entry.php for JIT probe).

Test plan

make bootstrap-selfhost-jit-unit-probe-strict
# → emit_path=native, inventory compile_driver (no emit-helper TU, #2879/#3038)

BOOTSTRAP_M3_USE_INVENTORY_EMIT_DRIVER=0 make bootstrap-selfhost-jit-unit-probe-strict
# → bisect: legacy jit_unit_probe_m3_emit_native_entry.php path

vendor/bin/phpunit --filter BootstrapJitUnitProbeTest

Verified (Docker):

bootstrap-selfhost-jit-unit-probe: OK emit_path=native ... inventory compile_driver (#2879/#3038)
jit-unit-probe-aot stdout: jit unit probe compile OK
PHPUnit BootstrapJitUnitProbeTest: 14/14 OK

Closes #3038

Made with Cursor

Wire test/selfhost/jit_unit_probe/compile_driver.php into the strict
bootstrap probe (default on BOOTSTRAP_M3_JIT_UNIT_PROBE_STRICT=1),
retiring the dedicated emit-helper TU for native emit when inventory
driver is enabled — parity with compiler_unit_probe (#2879).

Verified: make bootstrap-selfhost-jit-unit-probe-strict → emit_path=native
  vendor/bin/phpunit --filter BootstrapJitUnitProbeTest → 14/14 OK
Co-authored-by: Cursor <cursoragent@cursor.com>
@PurHur
PurHur merged commit 722f6b3 into master May 29, 2026
@PurHur
PurHur deleted the issue-3038-jit-unit-probe-inventory-emit branch July 16, 2026 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Self-host M3: wire inventory compile_driver in bootstrap-selfhost-jit-unit-probe.sh

1 participant