Language: emit Undefined array key Warning on dim ++/-- (#30078) - #30158
Merged
Merged
Conversation
Zend warns when incrementing/decrementing a missing array key before coercing null and storing the result. Match that for VM FETCH_DIM_W followed by inc/dec and JIT dimFetch write paths. Co-authored-by: Cursor <cursoragent@cursor.com>
5 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Undefined array keyE_WARNING onFETCH_DIM_Wwhen the next opcode is pre/post inc/dec and the key is missing (Language: $a[missing]++ omits Undefined array key Warning — Zend warns then treats as null (zend_execute.c) #30078).offsetIsSetDimbefore write dimFetch for inc/dec and call__compiler_undefined_array_key_warning_*when absent.test/compliance/cases/language/dim_inc_undefined_array_key_warning.phpt.Verification
Issue repro (VM + JIT,
PHP_COMPILER_PROFILE=8.4):Output (both backends):
Not covered
VMTest/JITTestshards; bootstrap/self-host gates (language-only VM/JIT change).Closes #30078
Made with Cursor