Stdlib: substr_compare null $case_insensitive Z_PARAM_BOOL (#29756) - #29787
Merged
Merged
Conversation
Match php-src string.c — TypeError under strict_types; soft-null DEP+coerce otherwise. Early-return after compile-time null TypeError so AOT try/catch does not emit IR after a terminator. Co-authored-by: Cursor <cursoragent@cursor.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
substr_compare(..., null)$case_insensitiveto match php-srcext/standard/string.cZ_PARAM_BOOL: TypeError understrict_types, soft-null DEP+coerce otherwise.VmMath::parseBoolBuiltinArgForFrame; JIT/AOT usesJitBoolArg::lowerCoerceZParamBoolwith an early return after compile-time null TypeError so try/catch AOT does not emit IR after a terminator.LogicException“must be boolean in this compiler build” shortcut.Closes #29756
php-src reference
ext/standard/string.c—Z_PARAM_BOOL/php_substr_compare$case_insensitiveTest plan
TypeError: … $case_insensitive must be of type bool, null givenbin/compile.php+ run oftest/repro/issue_substr_compare_null_ci_aot.phpvendor/bin/phpunit --filter SubstrCompareNullCi→ OK (4)vendor/bin/phpunit --filter substr_compare_null_ci_strict→ OK (includes AotTest)Not covered / pillar note
north-star5-verify-fast/ release-readiness currently red on master for spine missinglib/JIT/TypedParamCoerce.php(unrelated to this change).Made with Cursor