Repository navigation
Language: object array key via new in try throws Illegal offset type (#29532) - #29539
Merged
Merged
Conversation
…29532) Merge-echo phi collision remapped the live `new` temp after TYPE_NEW, so the dim key became null→"" instead of TypeError. Copy non-literal dims into a fresh slot like MethodCall receivers. Co-authored-by: Cursor <cursoragent@cursor.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
try,$a[new T()] = …was writing key""(null coerce) instead of throwingTypeError: Illegal offset typewhen the dim temp collided with a merge-echo phi slot.freshLiteralConstantSlot()on non-literals calledforceFreshVarSlot()on the livenewTemporary afterTYPE_NEWhad already stored the object — remapping left an empty dim slot.Closes #29532
Test plan
test/repro/illegal_offset_object_key_new_in_try_29532.php; noTOSTRING/AFTER_*)php vendor/bin/phpunit --filter IllegalOffsetObjectKeyNewInTryTest→ OK (1 test, 4 assertions).phptadded:illegal_offset_object_key_new_in_try.phptci-local/ compliance suite /--strictnorth-starTrust gates before claim
./script/release-readiness.sh --json→user_release_ready: yes,north-star5-fast: okMade with Cursor