Skip to content

Stdlib: stream_filter_append/prepend Reflection Zend names (#28908) - #29258

Merged
PurHur merged 1 commit into
masterfrom
fix/28908-stream-filter-append-reflection
Aug 9, 2026
Merged

PurHur merged 1 commit into
masterfrom
fix/28908-stream-filter-append-reflection

Conversation

@PurHur

@PurHur PurHur commented Aug 9, 2026

Copy link
Copy Markdown
Owner

Summary

  • Fix stream_filter_append / stream_filter_prepend Reflection param names to Zend filter_name / mode / params (was filtername / read_write / filterparams).
  • Clear bogus resource return type (php-src stubs leave return untyped).
  • Accept named filter_name: / mode: / params:.
  • PHP-in-PHP only (BuiltinParamNames + BuiltinInternalArgInfo + TypeError labels).

Closes #28908

Test plan

  • php bin/vm.php test/repro/issue_28908_stream_filter_append_reflection.php
  • vendor/bin/phpunit --filter "StreamFilterAppendPrependReflectionVMTest|testStreamFilterAppendPrependZendStubNamedParamsAndReturn"

Verification transcript

$ php bin/vm.php test/repro/issue_28908_stream_filter_append_reflection.php
stream_filter_append [stream, filter_name, mode, params] ret=(none)
stream_filter_prepend [stream, filter_name, mode, params] ret=(none)
named_ok

$ vendor/bin/phpunit --filter "StreamFilterAppendPrependReflectionVMTest|testStreamFilterAppendPrependZendStubNamedParamsAndReturn"
OK (2 tests, 19 assertions)

php-src ref: ext/standard/basic_functions.stub.php. Not covered: full ci-fast.sh / AOT.

Made with Cursor

Advertise filter_name/mode/params and clear bogus resource return so named
args match php-src basic_functions.stub.php.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant