Repository navigation
Stdlib: stream_filter_append/prepend Reflection Zend names (#28908) - #29258
Merged
Merged
Conversation
Advertise filter_name/mode/params and clear bogus resource return so named args match php-src basic_functions.stub.php.
This was referenced Aug 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
stream_filter_append/stream_filter_prependReflection param names to Zendfilter_name/mode/params(wasfiltername/read_write/filterparams).resourcereturn type (php-src stubs leave return untyped).filter_name:/mode:/params:.BuiltinParamNames+BuiltinInternalArgInfo+ TypeError labels).Closes #28908
Test plan
php bin/vm.php test/repro/issue_28908_stream_filter_append_reflection.phpvendor/bin/phpunit --filter "StreamFilterAppendPrependReflectionVMTest|testStreamFilterAppendPrependZendStubNamedParamsAndReturn"Verification transcript
php-src ref:
ext/standard/basic_functions.stub.php. Not covered: fullci-fast.sh/ AOT.Made with Cursor