Repository navigation
Stdlib: mb_convert_encoding() UUENCODE transfer encoding (#28981) - #29201
Merged
Merged
Conversation
Wire libmbfl UUENCODE transfer encoding through existing VmString uuencode helpers so PROFILE/php-src-strict matches Zend (begin header, decode, 8.2+ deprecation) instead of ValueError on a listed encoding. Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Aug 9, 2026
PurHur
added a commit
that referenced
this pull request
Aug 9, 2026
…(re-#29197) (#29206) Release-readiness went red again on tip: three lib/VM property-fetch helper fingerprints drifted with the dynamic-property deprecate path, and four mbstring units plus inventory construct flags drifted with #29201. Republish Docker-emitted fingerprints and regenerate bootstrap-inventory. Co-authored-by: PurHur <PurHur@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UUENCODEformb_convert_encoding()(encode withbegin 0644 filenameheader, decode via begin-line seek +convert_uudecode, identity = decode) matching php-srcmbfilter_uuencode.c.x-uuencode; emit PHP 8.2+ Uuencode deprecation when$to_encodingresolves to UUENCODE..phpt+ dedicatedMbConvertEncodingUuencodeVMTest.Closes #28981
php-src:
ext/mbstring/libmbfl/filters/mbfilter_uuencode.c,ext/standard/uuencode.cPHP:
ext/mbstring/VmMbstring.php,MbstringEncodingRegistry.phpTest plan
Hi/ empty /x-uuencode/ decode / identity) — byte-identicalvendor/bin/phpunit test/compliance/MbConvertEncodingUuencodeVMTest.php— OKMbEncodingAliasesSpecialVMTest+ QP test still OK./phpc buildofmb_convert_encoding("Hi","UUENCODE")and decode literals — OKmb_convert_encodingremains not JIT/AOT-lowered (pre-existing; same as other mb convert paths)Gate snapshot (tried-first)
Also closed invalid re-file #29189 (
XMLWriter::toStringnot in php-src).Made with Cursor