Repository navigation
Language: silence @ on assignment RHS (#29132) - #29133
Merged
Merged
Conversation
Materialize bare `@$cv` under ErrorSuppress via Assign into a temp so post-silence consumers do not re-fetch the CV (UnaryPlus coerced null→0). Co-authored-by: Cursor <cursoragent@cursor.com>
4 tasks
PurHur
added a commit
that referenced
this pull request
Aug 8, 2026
patches/php-cfg-bare-variable-read-stmt.patch changed coreFingerprint material, so the committed corpus was skipped wholesale and cold hello-world timed out. Honest --prelink republish: 370 fresh / 0 stale (Closes #29149). Co-authored-by: PurHur <PurHur@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
$a = @$undef;no longer emitsUndefined variableon VM/JIT (Zend-silent).#13587usedUnaryPlusinside@to force a CV check, but returned the original CV; post-END_SILENCEassign re-fetched it.UnaryPlusalso coerces null→0, so it cannot be the@expression value.@$cvwithAssigninto a temp under silence (preserves null); return that result. Compiler treatsAssignas an error-suppress primary for slot inheritance.php-src:
Zend/zend_compile.c/zend_execute.c(ZEND_BEGIN_SILENCE).Test plan
ok) — VM + JITvendor/bin/phpunit test/unit/ErrorControlOperatorTest.php— 3/3vendor/bin/phpunit --filter at_silence_assign_undef_rhs test/compliance/ErrorSuppressJITTest.php— OK#13587error_get_last_at_read_stmt.phptstill OK on VM@$b = 1/$x = @$c = 2unchanged vs ZendVerification transcript
Pre-triage:
user_release_ready: yes(north-star5-fast ok); inventory doc drift pre-existing on master (unrelated).Made with Cursor