Language: reject goto into switch like Zend (#28796) - #28813
Merged
Merged
Conversation
) php-cfg already tracked loop/switch scope for the desugar switch path, but scalar-case switches use compileJumptableSwitch which skipped the stack — so goto into switch ran. Push the same scope id there, throw CompileError instead of RuntimeException for clean exit 255, and guard with compliance + unit tests. Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Aug 8, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gotointo aswitchwas accepted on VM/JIT becausecompileJumptableSwitchnever pushedgotoLoopSwitchStack(desugar path already did).php-cfg-goto-scope-jumptable.patch+ prelinked mirror;validateGotoScopethrows\CompileError(clean exit 255, no host stack dump)..phpt(file-scope +eval) and unit guards.php-src:
Zend/zend_compile.c—'goto' into loop or switch statement is disallowed.Test plan
'goto' into loop or switch statement is disallowed, noHITevalgoto-into-switch: exit 255, Zend-shaped Fatalvendor/bin/phpunit --filter GotoStatementTest— OK (7)vendor/bin/phpunit test/compliance/GotoVMTest.php— OK (11)script/apply-patches.shskips jumptable patch when already appliedVerification transcript
Made with Cursor