Repository navigation
Language: drop isAnonymousClass() free-function phantom (#28616) - #28736
Merged
Merged
Conversation
php-src only ships ReflectionClass::isAnonymous(); stop registering and advertising the free function on every php-src-strict profile. Co-authored-by: Cursor <cursoragent@cursor.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isAnonymousClass()is absent from php-src; onlyReflectionClass::isAnonymous()/ReflectionFunction::isAnonymous()exist.CompilerVersion::supportsIsAnonymousClass()/advertisesIsAnonymousClass()now always returnfalseon php-src-strict profiles (including PROFILE=8.4/8.5), soext/reflectionno longer registers the free function.ext/reflection/php_reflection.stub.php. PHP:lib/CompilerVersion.php+ext/reflection/Module.phpgate.Closes #28616
Test plan
PHP_COMPILER_PROFILE=8.4|8.5|8.2 php bin/vm.php test/repro/issue_28616_isanonymousclass_phantom.php→ok: isAnonymousClass withheld; ReflectionClass::isAnonymous worksPHP_COMPILER_PROFILE=8.4|8.5 php bin/jit.php -r 'var_export(function_exists("isAnonymousClass")); echo "\n";'→false./script/phpunit.sh test/compliance/IsAnonymousClassPhantomVMTest.php→ OK./script/phpunit.sh test/compliance/IsAnonymousClassPhantomJITTest.php→ OK./script/phpunit.sh --filter 'Issue28616IsAnonymousClassPhantomTest|testIsAnonymousClassNeverAdvertisedOnForwardProfile|testLazyObjectFactoriesEnabledOnForwardProfile'→ OK (3 tests, 54 assertions)Gate snapshot (pre-claim / master)
docker info: ok./script/release-readiness.sh --json:user_release_ready: yes(north-star5-fast ok; gen-0 provenance stale warning only)Not covered
ReflectionClass::isAnonymous()on anonymous classes still segfaults on this host (pre-existing; out of scope — free-function retirement only). VM path verified.Made with Cursor