[PurHur]

Summary

• Fixes array-literal enum/object keys still throwing legacy Illegal offset type under PHP_COMPILER_PROFILE=8.4 while $a[$enum]=… already used Zend’s typed message (Closes #28628).
• Root cause: INIT_ARRAY / ADD_ARRAY_ELEMENT threw a bare TypeError for TYPE_OBJECT/TYPE_ARRAY before EnumCaseSupport::rejectIllegalArrayOffset.
• Reuse the shared zend_illegal_container_offset formatter for VM literals and JIT addElement / dim-write object keys (php-src-strict).

php-src reference

• Zend/zend_hash.c — illegal key TypeError
• Zend/zend.c — zend_illegal_container_offset()

PHP implementation

• lib/VM.php — INIT_ARRAY / class-body defaults call rejectIllegalArrayOffset first
• lib/VM/EnumCaseSupport.php — formatIllegalContainerOffsetMessage() shared helper
• lib/JIT/HashTableHelper.php / HashTableWriteLlvm.php / Variable.php — typed JIT messages from compile-time enum class hints

Test plan

• Issue repro:

  ./script/docker-exec.sh -- bash -lc 'source script/php-env.sh
  PHP_COMPILER_PROFILE=8.4 php bin/vm.php test/repro/maintainer_enum_array_literal_key_msg.php
  PHP_COMPILER_PROFILE=8.4 php bin/jit.php test/repro/maintainer_enum_array_literal_key_msg.php
  '

  Output (both):

  unit: TypeError:Cannot access offset of type E on array
  unit-assign: TypeError:Cannot access offset of type E on array
  backed: TypeError:Cannot access offset of type S on array
  backed-assign: TypeError:Cannot access offset of type S on array
  

• PHP_COMPILER_PROFILE=8.2 still emits Illegal offset type (legacy)
• vendor/bin/phpunit --filter EnumCaseTypeNameTest — OK (5 tests)

Made with Cursor