Repository navigation
Self-host M3: real-lower ConstStringFolder helpers for M3 compile driver - #2837
Merged
Merged
Conversation
…e driver. fold() called stubbed literalStringValue/magicScriptConstValue callees and broke __DIR__/__FILE__ include-path folding when the M3 compile driver was active. Whitelist helper FUNCDEFs for PHP CFG lowering and allow them in the emit-TU gate. Closes #2827 Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ConstStringFolderprivate helpers (literalStringValue,magicScriptConstValue,sourceDir, CFG walkers,foldDeployPathConcat) sofold()/foldConcat()callees are not stubbed no-ops during native link.PHP_COMPILER_M3_COMPILE_DRIVER=1.Why
fold()was real-lowered but called separate FUNCDEFs that still returned stub nulls, breaking__DIR__/__FILE__include-path folding onbin/compile.phpand driver-scale bundles (#2827).Test plan
vendor/bin/phpunit --filter JitCompilerSelfHostStubTestmake bootstrap-selfhost-linkPHP_COMPILER_M3_SOURCE=bin/compile.php ./script/bootstrap-selfhost-helloworld-compile-bin.shBOOTSTRAP_M3_HELLOWORLD_STRICT=1 ./script/bootstrap-selfhost-helloworld-probe.sh→emit_path=nativeCloses #2827
Made with Cursor