Repository navigation
Language: enum implements metadata in CFG/VM (#2299) - #2830
Merged
Merged
Conversation
Parse `enum Foo: T implements Bar` in php-cfg, emit classImplements on TYPE_DECLARE_ENUM, and store interfaces on ClassEntry for self-host subset v1. Co-authored-by: Cursor <cursoragent@cursor.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
enum Foo: T implements Barin php-cfg ($implementsonPHPCfg\Op\Stmt\Enum_).classImplementsonTYPE_DECLARE_ENUMinlib/Compiler.php.ClassEntryduring VM enum registration.patches/php-cfg-enum-implements.patch+ overlay apply hook inscript/apply-patches.sh.Test plan
php bin/vm.php -r 'interface L {} enum S: string implements L { case A = "x"; } echo S::A;'enum_implements_metadata.phpt(runs inVMTestdata provider)make bootstrap-selfhost-link(Docker)Advances #1492 / closes slice 1 of #2299 (metadata only; enum methods deferred).
Made with Cursor