Repository navigation
Fix AOT array_first/array_last wrong output under PROFILE=8.5 (#27596) - #28105
Merged
Merged
Conversation
NestedJIT ArrayElemJitHelper returns wrong values under thin standalone AOT; route user-script builds through pure LLVM (peer HashTableShiftLlvm #24025) while JIT/MCJIT keep the php-in-PHP helper bridge. Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HashTableElemLlvmpure-LLVM path forarray_first()/array_last()under thin standalone AOT (peerHashTableShiftLlvm/ REGRESSION: e30_array_lit_dim_assign_shift no longer compiles — HashTable::shiftFirst() unresolved #24025).ArrayElemRuntime::first/lastthrough LLVM whenisThinStandaloneAotMain(); JIT/MCJIT keepArrayElemJitHelperphp-in-PHP bridge.JitVmHelperLink::ensureBridge/ensureCompiledwith optionalskipHelperRuntimeCachefor future thin-AOT helper bundles.Problem
NestedJIT
ArrayElemJitHelperVariable returns were wrong (NULL/Object) or segfaulted underphpc buildwhile VM/JIT matched Zend (#27596).Verification
Not covered
json_encode([...])in the issue repro still aborts under thin AOT (AOT: var_dump() aborts (SIGABRT) with no diagnostic — even var_dump(7) #23540) — orthogonal to array_first/last values.north-star5-verify --strict/ bootstrap blob refresh.ArrayElemJitHelper(thin AOT no longer uses cached unit for these builtins).Closes #27596
Made with Cursor