Skip to content

AOT: remove shell_exec from Linker #2790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PurHur merged 1 commit into from
May 27, 2026
Merged

AOT: remove shell_exec from Linker #2790

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 42 additions & 15 deletions lib/AOT/Linker.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,31 @@ final class Linker
'password_crypto.c',
];

private static function which(string $binary): ?string
{
if ('' === $binary) {
return null;
}
if (str_contains($binary, '/')) {
return is_file($binary) && is_executable($binary) ? $binary : null;
}
$path = getenv('PATH');
if (false === $path || '' === $path) {
return null;
}
foreach (explode(':', $path) as $dir) {
if ('' === $dir) {
continue;
}
$candidate = rtrim($dir, '/').'/'.$binary;
if (is_file($candidate) && is_executable($candidate)) {
return $candidate;
}
}

return null;
}

public static function link(string $objectFile, string $executable): void
{
$runtimeObjects = self::compileRuntimeObjects($objectFile);
Expand Down Expand Up @@ -175,8 +200,8 @@ private static function compileRuntimeObjects(string $objectFile): array
private static function resolveRuntimeCompiler(): string
{
foreach (['gcc', 'cc', 'clang'] as $name) {
$path = trim((string) shell_exec('command -v '.escapeshellarg($name).' 2>/dev/null'));
if ('' !== $path) {
$path = self::which($name);
if (null !== $path) {
return $path;
}
}
Expand All @@ -196,8 +221,8 @@ private static function resolveBundledClang(): string
}
}
foreach (['clang-9', 'clang'] as $name) {
$path = trim((string) shell_exec('command -v '.escapeshellarg($name).' 2>/dev/null'));
if ('' !== $path) {
$path = self::which($name);
if (null !== $path) {
return $path;
}
}
Expand Down Expand Up @@ -250,14 +275,16 @@ private static function discoverSystemIncludeDirs(): array
{
$dirs = [];
foreach (['gcc', 'cc', 'clang'] as $compiler) {
$path = trim((string) shell_exec('command -v '.escapeshellarg($compiler).' 2>/dev/null'));
if ('' === $path) {
$path = self::which($compiler);
if (null === $path) {
continue;
}
$verbose = shell_exec(
escapeshellarg($path).' -E -Wp,-v -xc /dev/null 2>&1'
$captured = self::runCaptured(
escapeshellarg($path).' -E -Wp,-v -xc /dev/null',
null
);
if (!is_string($verbose)) {
$verbose = $captured['stderr']."\n".$captured['stdout'];
if ('' === trim($verbose)) {
continue;
}
$capture = false;
Expand Down Expand Up @@ -297,8 +324,8 @@ private static function resolveClang(): string
{
// Runtime C needs system libc headers; bundled LLVM clang often lacks them.
foreach (['cc', 'gcc', 'clang'] as $name) {
$path = trim((string) shell_exec('command -v '.escapeshellarg($name).' 2>/dev/null'));
if ('' !== $path) {
$path = self::which($name);
if (null !== $path) {
return $path;
}
}
Expand All @@ -307,8 +334,8 @@ private static function resolveClang(): string
$llvmPrefix = (false !== $llvmDir && '' !== $llvmDir) ? realpath($llvmDir) : false;
// Prefer the host toolchain for runtime C: bundled LLVM clang often lacks system headers.
foreach (['clang', 'gcc', 'cc'] as $name) {
$path = trim((string) shell_exec('command -v '.escapeshellarg($name).' 2>/dev/null'));
if ('' === $path) {
$path = self::which($name);
if (null === $path) {
continue;
}
if (false !== $llvmPrefix && str_starts_with($path, $llvmPrefix)) {
Expand Down Expand Up @@ -377,8 +404,8 @@ private static function linkWithSystemCompiler(
$objects .= ' '.escapeshellarg($runtimeObject);
}
foreach ($linkers as $linker) {
$path = trim((string) shell_exec('command -v ' . escapeshellarg($linker) . ' 2>/dev/null'));
if ('' === $path) {
$path = self::which($linker);
if (null === $path) {
continue;
}
$cmd = escapeshellarg($path) . ' '
Expand Down