Repository navigation
Stdlib: openssl_pkey_derive Reflection + named args (#27685) - #27846
Merged
Merged
Conversation
Wire Zend stub arity/names/types/return via BuiltinParamNames and BuiltinInternalArgInfo so Reflection and named public_key/private_key match php-src (absent from php-types InternalArgInfo). Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Aug 5, 2026
PurHur
added a commit
that referenced
this pull request
Aug 5, 2026
…27864) * Trust: honest gen-0 argv refresh after #27846–#27863 drift (#27860) Rebuild prelinked/bootstrap-gen0 argv driver from current tip so lowering_source_fingerprint matches live sources (no restamp). Co-authored-by: Cursor <cursoragent@cursor.com> * Trust: prune thin-AOT KeySort/ValueSort helper orphans (#27860) #27863/#27227 retired NestedJIT HELPER_PATH sites for ksort/krsort and asort/arsort in favor of HashTable LLVM; fingerprint-stale committed units made helper-runtime-prelink --strict fail release-readiness. Co-authored-by: Cursor <cursoragent@cursor.com> --------- Co-authored-by: PurHur <PurHur@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
openssl_pkey_derive()(public_key,private_key,int $key_length = 0→string|false) — function was absent from php-typesInternalArgInfo, so arity was 0 and named args failed withUnknown named parameter.BuiltinParamNames/BuiltinInternalArgInfo/BuiltinInternalDefaultValues; noruntime/C.ext/openssl/openssl.stub.php.Closes #27685
Test plan
peer_key)./script/phpunit.sh test/compliance/OpensslPkeyDeriveReflectionVMTest.php— OK./script/phpunit.sh --filter testOpensslPkeyDeriveNamedParamsResolve test/unit/BuiltinParamNamesAliasTest.php— OK./script/phpunit.sh --filter 'testOpensslPkey|openssl_pkey_derive' test/unit/OpensslModuleTest.php— OK (2 tests)php bin/vm.php test/repro/maintainer_gap_openssl_pkey_derive_reflection.phpci-local/ AOT (runtime already VM-only for derive; Reflection-only change)north-star5-fastred on master (gen-0 manifest mismatch Self-host M5: bootstrap-inventory argv driver size floor — grow beyond 451KB stub #8713) — unrelatedVerification transcript
Made with Cursor